Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Copyright headers, add workflow to enforce #4764

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

puerco
Copy link
Contributor

@puerco puerco commented Oct 17, 2024

Summary

This workflow updates the copyright headers of all the go code and yaml files. It updates them to credit "The Minder Authors" and updates the files to use SPDX license identifiers instead of plain text. The original copyright year of the files has been preserved.

This PR also adds a workflow to check the copyright headers as a presubmit and includes the template boilerplates for go, shel and yaml.

Note that this PR temporarily removes the migration modification check. Once we merge this I will revert
b182d78 and reenable the touch check.

Fixes stacklok/minder-stories#56

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@puerco puerco force-pushed the boilerplates branch 8 times, most recently from 66444d5 to d1369b8 Compare October 17, 2024 06:50
This commit adds the boilerplates for the code. Included are headers
for go, yaml and shell scripts

Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
This commit adds a workflow to check for the license boilerplates
using chainguard-dev/action/boilerplates

Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
This commit modifies all the go code and yaml files to update the copyright headers
to credit "The Minder Authors" and use SPDX License identifiers instead of text.

Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
This commit temporarily removes the migration check as we are altering all the files.
Once the copyright headers are updated, this PR will be reverted.

Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
@puerco puerco merged commit 7a669b5 into mindersec:main Oct 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants